search

dgsuarez / reruby

Refactor Ruby
MIT License
35 stars 2 forks source link

Autocommit option #37

Closed ZeusPerez closed 5 years ago

ZeusPerez commented 5 years ago

For issue #33

Maybe you find some incoherence in the way I added the autocommit in the differet refactor class (sometimes I added a method and sometimes I inlined the conditional in the perform). That's because I wanted to follow the style of the .perform in each class.

Another idea for implementing this is to add a kind of before_filter when executing the .perfom, but I'm not sure if you want to have the flag options in all the refactor.

Let me know your ideas about this, :)

dgsuarez commented 5 years ago

As for the before_filter idea, yeah, I guess the code is leading us that way, there's this as a before step and the rubocop cleanup as after. Not sure about the best way to implement it, maybe some sort of DefaultSteps role to be included for each refactor...

ZeusPerez commented 5 years ago

Thanks for the review! I've made the changes you requested, take a look at them and let me know if they are ok!