dgtlmoon / changedetection.io-browser-extension

A super simple and helpful way to add websites to monitor
Apache License 2.0
13 stars 1 forks source link

Doesn't work in Firefox #5

Open iG8R opened 5 months ago

iG8R commented 5 months ago

I installed this extension (addon) in Firefox, it only shows the Not yet configured... popup and when I click on the Sync API Access button, it only changes its label to Checking for access key and nothing else happens.

changedetection.io-Firefox-Video_2024-03-17_21-15-25.webm

PS. Enabling/disabling API access token security check enabled has no effect on this issue. PPS. To make it work in Firefox, I needed to correct manifest.json in the following way:

{
  "name": "Changedetection.io Website Monitor",
  "description": "Helps you to easily add websites to your changedetection.io profile.",
  "version": "0.2.1",
  "manifest_version": 3,
  "permissions": [
    "activeTab",
    "background",
    "notifications",
    "storage",
    "tabs",
    "scripting"
  ],
  "action": {
    "default_popup": "popup.html",
    "default_icon": {
      "16": "/images/shortcut-16.png",
      "32": "/images/shortcut-32.png",
      "48": "/images/shortcut-48.png",
      "128": "/images/shortcut-128.png"
    }
  },
  "icons": {
    "16": "/images/shortcut-16.png",
    "32": "/images/shortcut-32.png",
    "48": "/images/shortcut-48.png",
    "128": "/images/shortcut-128.png"
  },
  "incognito": "spanning",
  "background": {
    "scripts": ["background.js"]
  },
  "browser_specific_settings": {
    "gecko": {
    "id": "changedetection.io@changedetection.io"
    }
  }
}
iG8R commented 5 months ago

I asked myself and I'll answer it myself.

  1. \changedetection.io-browser-extension-master\src\background.js
 22:            chrome.scripting.executeScript({
 23:                 target: {tabId: tabs[0].id},
+24:                 func: getElementsContent
-24:                 function: getElementsContent
 25:               }).then(([result]) => {
  1. \changedetection.io-browser-extension-master\src\manifest.json
 6:   "permissions": [
 7:     "activeTab",
-8:         "background",
 9:     "notifications",
 10:        "storage",
atikattar1104 commented 3 weeks ago

Try Opening A PR For This. That Would Make It Useful For More Devs To Be Able To Help Creating A Firefox Variant Of This.