Closed mrapacz closed 2 weeks ago
@mrapacz can you write a pytest test case to show it and make a PR? :)
btw, any difference if you use jq: .price
or jq:.price
?
btw, any difference if you use
jq: .price
orjq:.price
?
Nope, same bevahiour!
@mrapacz can you write a pytest test case to show it and make a PR? :)
Sure - if you confirm it's a bug, I'll be happy to draft a test and look into this when I get a moment, though it's a relatively low priority for me atm - I figured I'll follow-up #1495 with a bunch of issues related to things that surprised/bugged me mostly to provide more feedback rather than attempt to address them myself 😅 But I'm happy to contribute as well as much as my availability allows ;)
@mrapacz I have the same situation - no time to spend on this issue unfortunately, so the only solid way to start is if you can provide a PR with just a pytest to prove it, then I can dive deeper into the architecture etc
Confirmed it works now, closing. Thanks!
Describe the bug Was not sure whether to file it as a bug or a feature request, it feels like the 'price tracking' feature is just not complete yet :) (I checked other issues, but haven't found anything directly related to my request)
Currently if you add a certain site and changedetection.io detects price data within it, it will offer to track the price. I just stumbled upon this use case:
It turns out the practice of this shop is to update the
priceValidUntil
every day to<today> + <1 year>
. This means that if I were to track this item like this, I'd be getting one notification per day, since the json changes. I'm actually interested in the price part only, though.jq: .price
in this case I get the following:So it seems like what happens is the software tries to extract .price from the site (which fails and hence null) and then append the extracted price to the output.
Version 0.42.2
To Reproduce
Expected behavior I'd expect the jq/jsonpath filters to work on the extracted price object.
Screenshots If applicable, add screenshots to help explain your problem. This is how the diff looks after adding
jq: .price
to the watch:Desktop (please complete the following information):
Additional context Add any other context about the problem here.