dgtlmoon / changedetection.io

The best and simplest free open source web page change detection, website watcher, restock monitor and notification service. Restock Monitor, change detection. Designed for simplicity - Simply monitor which websites had a text change for free. Free Open source web page change detection, Website defacement monitoring, Price change notification
https://changedetection.io
Apache License 2.0
18.92k stars 1.03k forks source link

[feature] Environmental variables on the notification URL list #2141

Open cellulosa opened 9 months ago

cellulosa commented 9 months ago

hi there, I am setting my mail notifier and would like to use environmental variables like so:

mailtos://outlook.com?smtp=smtp-mail.outlook.com&user=${MY_EMAIL}&pass=${MY_PASSWORD}

Is it possible?

dgtlmoon commented 9 months ago

No but that's a great idea! I'll add that soon for the next release

dgtlmoon commented 9 months ago

I'm worried that this could leak environmental vars from the hosting environment too easy, for example amazon stores a few credentials for the DB etc in the environment vars... I'm not sure this is a good idea

dgtlmoon commented 9 months ago

Maybe some docker-compose.yml extra settings that can list exactly which env-vars are permitted might be the solution

PERMITTED_ENV_VARS_NOTIFICATION=MY_EMAIL,SOMETHINGELSE,VERSION,ETC

s8525c commented 8 months ago

I would need a way to pass the credentials in a safe way, not in clear text in the notifications settings page which anyone with access to the app would be able to read. I think that the environment variables suggestion would be safer than the current solution.

dgtlmoon commented 8 months ago

maybe headers.txt file could also be read from notifications URL

s8525c commented 8 months ago

I just started using changedetection.io and I don't know exactly what you are referring to. Could you please elaborate a bit more or point me to the right piece of documentation?

s8525c commented 8 months ago

Apprise can use a configuration file which could be good enough, but there is no way to use it as changedetection.io needs a non empty Notification URL List. This is a great tool, but a feature like this will make it even better.

s8525c commented 8 months ago

maybe headers.txt file could also be read from notifications URL

Oh, this is what you mean. Thank you, I will give it.