search

dgtlmoon / changedetection.io

The best and simplest free open source web page change detection, website watcher, restock monitor and notification service. Restock Monitor, change detection. Designed for simplicity - Simply monitor which websites had a text change for free. Free Open source web page change detection, Website defacement monitoring, Price change notification
https://changedetection.io
Apache License 2.0
15.85k stars 884 forks source link

[feature] Allow ignore_status_code to be a global option #2344

Open Etnies119 opened 2 months ago

Etnies119 commented 2 months ago

Version and OS Docker 0.45.21

Is your feature request related to a problem? Please describe. A feature request to have Ignore Status Code be one of the following:

A global setting A tag when importing a large number of URLS

Describe the solution you'd like I am importing ~100 URLs that are not currently live. I would like to receive a notification when the site goes live.

No notification is sent unless the option 'ignore_status_code = true'

This means manually editing 100 connections

Describe the use-case and give concrete real-world examples Import a URL that cannot be resolved and receive the following error: "Failed to establish a new connection: [Errno -2] Name or service not known"

Have the URL go live and add an image.

No notification is sent

Additional context Add any other context or screenshots about the feature request here.

dgtlmoon commented 2 months ago

No notification is sent unless the option 'ignore_status_code = true'

OK

Import a URL that cannot be resolved and receive the following error: "Failed to establish a new connection: [Errno -2] Name or service not known"

the actual 'difference' is still ignored yet, it does NOT use the "Failed to establish a new connection: [Errno -2] Name or service not known" text as a difference...

ignore_status_codes = BooleanField('Ignore status codes (process non-2xx status codes as normal)', default=False)

the ignore_status_codes is only to treat 404 etc like a 200 page...

so im confused about your request here

Etnies119 commented 2 months ago

No notification is sent unless the option 'ignore_status_code = true'

OK

Import a URL that cannot be resolved and receive the following error: "Failed to establish a new connection: [Errno -2] Name or service not known"

the actual 'difference' is still ignored yet, it does NOT use the "Failed to establish a new connection: [Errno -2] Name or service not known" text as a difference...

ignore_status_codes = BooleanField('Ignore status codes (process non-2xx status codes as normal)', default=False)

the ignore_status_codes is only to treat 404 etc like a 200 page...

so im confused about your request here

Ah I think it's because the site in question gets a DNS name several hours in advanced which returns a 404 error. Then when an image is added it doesn't send a notification. (It will when 'ignore_status_code' = true)

dgtlmoon commented 2 months ago

Ah I think it's because the site in question gets a DNS name several hours in advanced which returns a 404 error. Then when an image is added it doesn't send a notification. (It will when 'ignore_status_code' = true)

yeah either way, its a good request :)