search

dgtlmoon / changedetection.io

The best and simplest free open source web page change detection, website watcher, restock monitor and notification service. Restock Monitor, change detection. Designed for simplicity - Simply monitor which websites had a text change for free. Free Open source web page change detection, Website defacement monitoring, Price change notification
https://changedetection.io
Apache License 2.0
17.12k stars 957 forks source link

Use active_tag_uuid in URLs everywhere #2379

Closed AlexanderS closed 4 months ago

AlexanderS commented 4 months ago

Once active_tag was the UUID of the tag, but now it is a dict with the various properties of the tag. For building the different URLs we need to use the UUID.

This was broken since af747e6e3f66a0512317c0c6ea22e19bf622f192.

dgtlmoon commented 4 months ago

amazing, thanks! i'll add a test

dgtlmoon commented 4 months ago

This PR looks like a combo of just a small refactor and fixing some other bugs, but it would be nice if you can say which parts are fixing bugs and which part is just refactoring

maybe you can close this PR and make 2 separate PR's? its impossible to tell what is "fixed" and what is refactor here