Basic fast Plaintext/HTTP Client: `User-Agent/user-agent` not working

[leiless]

Describe the bug

Set User-Agent/user-agent request header in Basic fast Plaintext/HTTP Client is not working.

Version v0.45.23

Expected behaviour The Basic fast Plaintext/HTTP Client should honor the User-Agent / user-agent, but itsn't.

To Reproduce

Steps to reproduce the behavior:

1. Paste https://httpbin.org/headers and click Edit/Watch
2. Set to use the Basic fast Plaintext/HTTP Client
3. Click Show advanced options
4. Set Request headers:

   User-Agent: curl/7.88.0

5. Set CSS/JSONPath/JQ/XPath Filters to jq: .headers |= del(.["X-Amzn-Trace-Id"])
6. Click Save

{
    "headers": {
        "Accept": "*/*",
        "Accept-Encoding": "gzip, deflate, br",
        "Host": "httpbin.org",
        "User-Agent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.66 Safari/537.36"
    }
}

Additional context

I've also tried user-agent: curl/7.88.0, still not working.

user-agent: curl/7.88.0
User-Agent: curl/7.77.0

Also not working.

---

User-Agent: curl/7.77.0
user-agent: curl/7.88.0

It's weird but working, the output user-agent is the curl/7.88.0.

[dgtlmoon]

thanks!

after re-reading and re-reading your post, i guess you're saying it works but only when lowercase user-agent or? i dont quite follow

works OK..

[leiless]

I'm using a self-hosted (Linux aarch64) instance. And after I restarted my instance, this problem still exists.

Not working case 1

User-Agent: curl/7.77.0

Not working case 2

user-agent: curl/7.88.0

Not working case 3

user-agent: curl/7.88.0
User-Agent: curl/7.77.0

(lower-cased first)

Working but weird case 1

User-Agent: curl/7.77.0
user-agent: curl/7.88.0

(upper-cased first)

The output user-agent in change detection is curl/7.88.0.

[dgtlmoon]

@leiless can you click the 'share watch' icon and share the watch settings? i am totally unable to reproduce this

[dgtlmoon]

cannot reproduce

[dgtlmoon]

I see now :)

[leiless]

So what is the root cause by now?

[dgtlmoon]

@leiless look at the PR https://github.com/dgtlmoon/changedetection.io/pull/2409/files

[leiless]

Fixed by https://github.com/dgtlmoon/changedetection.io/releases/tag/0.45.24