search

dgtlmoon / changedetection.io

The best and simplest free open source web page change detection, website watcher, restock monitor and notification service. Restock Monitor, change detection. Designed for simplicity - Simply monitor which websites had a text change for free. Free Open source web page change detection, Website defacement monitoring, Price change notification
https://changedetection.io
Apache License 2.0
15.79k stars 883 forks source link

Upgrade eventlet - fix python 3.12 runtime issue - update requirements.txt #2414

Closed DWilly92 closed 2 weeks ago

DWilly92 commented 2 weeks ago

Updated the version of eventlet from 0.35.2 to any version greater than or equal to 0.36.1.

Running 0.35.2 causes an ssl error on launch, which causes changedetection.io to crash immediately when running Python 3.12.

dgtlmoon commented 2 weeks ago

Closes https://github.com/dgtlmoon/changedetection.io/pull/2288

dgtlmoon commented 2 weeks ago

@DWilly92 it also needs dnspython updated, see https://github.com/dgtlmoon/changedetection.io/pull/2288/files

thoughts?

dgtlmoon commented 2 weeks ago

https://github.com/dgtlmoon/changedetection.io/blob/bce02f9c82d2267a9b2bcbf8fd0be066250a7a9a/Dockerfile#L5

it also is broken in py 3.11/3.12., however we are ONLY testing as py3.10, so the test passing here is no real indication..

dgtlmoon commented 2 weeks ago

added tests for those other versions, and your commit is over at https://github.com/dgtlmoon/changedetection.io/pull/2419 :)

DWilly92 commented 2 weeks ago

Looks good, thanks for looking at that 👍