search

dgtlmoon / changedetection.io

The best and simplest free open source web page change detection, website watcher, restock monitor and notification service. Restock Monitor, change detection. Designed for simplicity - Simply monitor which websites had a text change for free. Free Open source web page change detection, Website defacement monitoring, Price change notification
https://changedetection.io
Apache License 2.0
17k stars 950 forks source link

Doesn't notify if a URL if it is inaccessible #2657

Closed profucius closed 3 hours ago

profucius commented 4 hours ago

Describe the bug I am using ChangeDetection to watch if a website is online or not, so that I can perform maintenance if it goes offline. This is a local site, not public. ChangeDetection successfully has access to the URL when the page is online, however when the page is offline (due to the docker container that hosts that page is offline), ChangeDetection provides an Exception and then does not notify me using the saved and tested notification method.

Exception: HTTPConnectionPool(host='browser-chrome', port=4444): 
Max retries exceeded with url: /wd/hub/session 
(Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7e1deeb39d10>: 
Failed to establish a new connection: [Errno -2] Name or service not known'))

Version v0.46.04

To Reproduce

Steps to reproduce the behavior:

  1. Watch a localhost URL that is accessible, then take that page down and Recheck in CD. 1b. If that's not possible, watch a website that does not exist, for instance: http://doesnotexist.com. I believe this will suffice as providing the same test environment.
  2. Notice that the notifications do not send to a destination.

Expected behavior I believe ChangeDetection should send a notification when the page cannot be accessed. If this is not yet a feature, then it should be added, as this is a valid need for an app that detections changes.

Desktop (please complete the following information):

dgtlmoon commented 4 hours ago

reads like duplicate of PR in progess https://github.com/dgtlmoon/changedetection.io/pull/1945