search

dgtlmoon / changedetection.io

The best and simplest free open source web page change detection, website watcher, restock monitor and notification service. Restock Monitor, change detection. Designed for simplicity - Simply monitor which websites had a text change for free. Free Open source web page change detection, Website defacement monitoring, Price change notification
https://changedetection.io
Apache License 2.0
17.37k stars 970 forks source link

[bug] Test notification does not work if there zero page watches #2725

Closed mikebgrep closed 1 hour ago

mikebgrep commented 1 day ago

Version and OS v0.47.03 docker image by linuxserver in Raspberry Pi

Is your feature request related to a problem? Please describe.

I face an issue after I deploy the app in a container.I have an error when there are no saved pages and I try to setup the mailtos Notification setting.The python return an error on the test notification option.I have the stacktrace but not right now.I got confused at first place.

Describe the solution you'd like I think it will be good to be included in the next release eventually, so the test notification works when there are no pages on the home page.

If this is not fixed in the latest build or nobody wants to check, I can take a look at the code if it is good to fix it.

dillfrescott commented 1 day ago

Screenshot 2024-10-19 202054

I think I'm running into the same issue...

dgtlmoon commented 2 hours ago

@dillfrescott what version is being run there?

dgtlmoon commented 2 hours ago

@dillfrescott could you supply a screenshot that shows what version is on pikapods?

mikebgrep commented 2 hours ago

https://github.com/dgtlmoon/changedetection.io/pull/2727 Mine issues are addressed in this PR.

dgtlmoon commented 1 hour ago

Strange thing is, i really feel like i've worked on a similar issue in the past, but no test was added so it probably raised its head again, but it wont happen anymore!