feat: Make compatible with Python 2 and Python 3 runtimes

dguest / pandamonium

Command line scripts to parse panda web api

BSD 3-Clause "New" or "Revised" License

27 stars 17 forks source link

feat: Make compatible with Python 2 and Python 3 runtimes #25

Closed matthewfeickert closed 4 years ago

matthewfeickert commented 4 years ago

Partially addresses #23 (might still be treated as Python 2 by default)

Use try and except blocks in the library imports to properly load the libraries that are divergent across Python 2 and Python 3. (Currently also showing the work of another PR)

[x] pandamon
[x] ~~panda-shortname~~ (contains no divergent imports)
[x] ~~panda-resub-taskid~~ (contains no divergent imports)
[x] ~~panda-kill-taskid~~ (contains no divergent imports)

matthewfeickert commented 4 years ago

@dguest This is ready for review.

We don't have CI yet, but I've been dogfooding this on atlasconnect and things work fine with Python2 still.

dguest commented 4 years ago

🤘