Closed matthewfeickert closed 4 years ago
@dguest This is one possible solution to Issue #36. Let me know your thoughts.
@dguest Given that GitHub Actions is deprecating set-env
and add-path
commands the pyhf
way of publishing is going to have to change so it seems that the method I'm implementing here is the best way forward for the time being.
This PR uses publication type releases to publish to PyPI by running the publication workflow on
published
release
events and then verifying that the PyPI upload step is running on one. This follows what I'll call thecorner
model (which I now think is how GitHub Actions assumed people would do things):This follows the example that is setup in
corner
with running the workflow onpublished
release
events and then only running the publish to PyPI step on that conditions. To instigate this workflow one would do the following:master
run:v0.2.0
) in the "Tag version" box and the "Release title" box (to make it easy unless you really want to get descriptive)This is a bit different from the
pyhf
way of doing things, but also lets things run through on TestPyPI on the tag before things are ever released.Additionally, this PR adds support for manual triggers of workflows through workflow dispatch
Recommended squash and merge commit message: