search

dguest / pandamonium

Command line scripts to parse panda web api
BSD 3-Clause "New" or "Revised" License
27 stars 17 forks source link

ci: Use Python 3.9 for tests in CI #56

Closed matthewfeickert closed 3 years ago

matthewfeickert commented 3 years ago

Suggested squash and merge commit message:

* Use Python 3.9 for packaging workflow
* Add Python 3.9 to PyPI metadata
* Remove --use-feature=2020-resolver from CI
   - Use of this flag will become an error in future releases of pip
dguest commented 3 years ago

Looks good, but one comment: We'll want to keep this working with some older versions of python too. Sadly I don't expect ATLAS to support 2.9 in most software releases any time soon. I don't know if we can do something to check that it still works with 2.7.

matthewfeickert commented 3 years ago

Looks good, but one comment: We'll want to keep this working with some older versions of python too. ...I don't know if we can do something to check that it still works with 2.7.

Yup, very much agree! At the moment we don't really have tests and this is just affecting the packaging CI. But once we do have real automated tests then it is very important that we test across all the Python runtimes we say we support. I've caught multiple issues where Python 3.6 and Python 3.8 have differing behavior in lower level stuff.