get_bool function parses String field value 'true' as boolean False

dgunning / edgartools

Python library for working with SEC Edgar

MIT License

345 stars 74 forks source link

get_bool function parses String field value 'true' as boolean False #14

Closed Iskaldr closed 9 months ago

Iskaldr commented 9 months ago

The current implementation of the edgar.core.get_bool function returns False, if the string field value is String 'true', therefore returning wrong reporting_relationship for some filings, e.g. this filing will be parsed to is_officer = False, but should be is_officer = True

dgunning commented 9 months ago

Thanks Christian, I am taking a look

dgunning commented 9 months ago

Fixed in 2..4.1.

dgunning commented 9 months ago

Fixed