search

dgunning / edgartools

Python library for working with SEC Edgar
MIT License
324 stars 70 forks source link

added missing fields from the submissions page #30

Closed rla3rd closed 4 months ago

rla3rd commented 5 months ago

I was just starting to play around with the raw rest api in a personal project when i came across this awesome project. I am making the attempt to modernize the dead github openedgar project. I plan on replacing all the broken api calls using your project, i'll send you updates if you don't mind as i find things missing. i sent you a linkedin invite too, thanks.

rla3rd commented 4 months ago

could also convert all those dict calls to .get() then it wouldnt matter

On Sun, Feb 11, 2024 at 3:15 PM Dwight Gunning @.***> wrote:

@.**** approved this pull request.

Seems okay. Will do some testing especially on none-company Entities just in case some of those fields are Optional

— Reply to this email directly, view it on GitHub https://github.com/dgunning/edgartools/pull/30#pullrequestreview-1874427281, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH5ZZ3HSPMISBTRSPGBHGLYTERGVAVCNFSM6AAAAABDDBATLSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZUGQZDOMRYGE . You are receiving this because you authored the thread.Message ID: @.***>

dgunning commented 4 months ago

Accepted. Will perform additional tests. Thanks

dgunning commented 4 months ago

Ran batch tests on around 700 person entities and it seems fine as is.

Thanks

Dwight

On Feb 11, 2024, at 3:18 PM, Rick Albright @.***> wrote:

could also convert all those dict calls to .get() then it wouldnt matter

On Sun, Feb 11, 2024 at 3:15 PM Dwight Gunning @.***> wrote:

@.**** approved this pull request.

Seems okay. Will do some testing especially on none-company Entities just in case some of those fields are Optional

— Reply to this email directly, view it on GitHub https://github.com/dgunning/edgartools/pull/30#pullrequestreview-1874427281, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH5ZZ3HSPMISBTRSPGBHGLYTERGVAVCNFSM6AAAAABDDBATLSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZUGQZDOMRYGE . You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/dgunning/edgartools/pull/30#issuecomment-1937858309, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALT4RYGXVQNAOTR346QYGTYTERQJAVCNFSM6AAAAABDDBATLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXHA2TQMZQHE. You are receiving this because you commented.

dgunning commented 4 months ago

Released 2.8.3 with this PR.

Thanks

On Feb 11, 2024, at 3:53 PM, Dwight Gunning @.***> wrote:

Ran batch tests on around 700 person entities and it seems fine as is.

Thanks

Dwight

On Feb 11, 2024, at 3:18 PM, Rick Albright @.***> wrote:

could also convert all those dict calls to .get() then it wouldnt matter

On Sun, Feb 11, 2024 at 3:15 PM Dwight Gunning @.***> wrote:

@.**** approved this pull request.

Seems okay. Will do some testing especially on none-company Entities just in case some of those fields are Optional

— Reply to this email directly, view it on GitHub https://github.com/dgunning/edgartools/pull/30#pullrequestreview-1874427281, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH5ZZ3HSPMISBTRSPGBHGLYTERGVAVCNFSM6AAAAABDDBATLSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZUGQZDOMRYGE . You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/dgunning/edgartools/pull/30#issuecomment-1937858309, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALT4RYGXVQNAOTR346QYGTYTERQJAVCNFSM6AAAAABDDBATLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXHA2TQMZQHE. You are receiving this because you commented.