Does not work properly with Monterey 12.1

Lear62 commented 2 years ago

Windows are no longer detected unless highlighted and not full screen

Lear62 commented 2 years ago

Yeah it's stopped working completely for me, only blurs the screen when I use the hotkey. Anybody still working on this?

dgurkaynak commented 2 years ago

Her @Lear62, sorry for the late response, I've just installed monterey on my mac (finally), and it's working seamless for me. Could you try to do a fresh install with all the permission stuff?

And if it's persisting, can you share penc logs?

ArkitectNaut commented 2 years ago

Works great for me on 12.2

Lear62 commented 2 years ago

Yes the issue is still there. I stopped using pence for a while but I'd like to try again, how do I share logs?

dgurkaynak commented 2 years ago

Start the application with logging enabled: open /Applications/Penc.app --args --enable-logging
Try to activate it by using hotkey
The log file is located in /tmp/penc.log

Lear62 commented 2 years ago

penc.log

dgurkaynak commented 2 years ago

Hey @Lear62, thanks for the logs. I guess I found the issue:

When an application is in fullscreen mode (via green window button), or it can be in split-view mode, it's not possible to resize those windows programmatically
That's why if a screen is in fullscreen mode, Penc doesn't show any of the windows in that screen -- just blurs it
And sadly there is no API to detect that. My workaround is checking whether a Finder window exists at the bottom of that screen and its size & position must match with that screen (https://github.com/dgurkaynak/Penc/blob/master/Penc/activation/Activation.swift#L49-L58)
All of your 3 screens are detected as in fullscreen mode, because Penc couldn't find those Finder windows
Then I suspect that Finder window does not exists because maybe desktop icons is manually hidden (via defaults write com.apple.finder CreateDesktop false, or via some app)
And boom! I can reproduce the same symptoms -- no window detected and everything is just blurred

Can you confirm this? Even if you do, I don't have any other idea to detect fullscreen mode 😕

Lear62 commented 2 years ago

So I definitely have nothing in fullscreen mode, however I do have my desktop hidden. After enabling my desktop again- BAM! Problem solved. Thanks! The question is if there's any way to make it detect windows while the desktop is hidden? And maybe if not, check if desktop is hidden and advise the user to enable it or the app won't function.

dgurkaynak commented 2 years ago

And maybe if not, check if desktop is hidden and advise the user to enable it or the app won't function.

That's definitely doable 👍 And also I will look again for other ways to detect fullscreen with this in mind.

Lear62 commented 2 years ago

Awesome, appreciate the help and app so much. While I'm at it, just wanted to throw out there that I'd really appreciate a setting that lets me scale a window horizontally while pinching horizontally just like vertical pinching scales vertical, instead of the whole window.

Lear62 commented 2 years ago

(while maintaining it's original center point please!!!)

ArkitectNaut commented 2 years ago

scale a window horizontally while pinching horizontally

That already exists by default, exactly how you described it. It is a bit finicky though.

dgurkaynak commented 2 years ago

That already exists by default, exactly how you described it. It is a bit finicky though.

Currently the threshold angle is 45, maybe we can add a sensitivity option to increase/decrease that angle?

ArkitectNaut commented 2 years ago

I guess that could be useful. I would love to have an option to retain the current size window but just centre it. Maybe a toggle to have the right-click gesture either minimize a window or centre it with current size.

Lear62 commented 2 years ago

scale a window horizontally while pinching horizontally

That already exists by default, exactly how you described it. It is a bit finicky though.

If it exists already, it's super finicky. For me scaling the window almost always goes from its center and scales out in all directions. Usually it doesn't even detect horizontal or vertical scale, this is along with the fact that it scales from the window's active center. Ideally if I slide a window to the bottom right I'd like to be able to adjust the height or width without it leaving the corner I placed it in, that would be amazing. Hope I explained it alright

dgurkaynak / Penc

Does not work properly with Monterey 12.1 #37