search

dgutman / osdAutoRegistration

An OpenSeadragon based viewer that leverages OpenCV Js to Register Two Images
0 stars 2 forks source link

Integrating slide picker and saving slide selection in local storage #14

Closed namandangi closed 1 year ago

namandangi commented 1 year ago

To-do:

  1. Integrate the slide selection dialog box with the other existing examples
  2. Add a mechanism to save the currently selected slide in the local storage for auto-populating the viewer on page refresh
pearcetm commented 1 year ago

@namandangi @dgutman Completed for the paper demo app. It would be more complicated to integrate this with the original app, and for now is not necessary.

dgutman commented 1 year ago

The original demo is not worth doing anything with.. just a reference

On Wed, Mar 15, 2023, 10:48 PM pearcetm @.***> wrote:

@namandangi https://github.com/namandangi @dgutman https://github.com/dgutman Completed for the paper demo app. It would be more complicated to integrate this with the original app, and for now is not necessary.

— Reply to this email directly, view it on GitHub https://github.com/dgutman/osdAutoRegistration/issues/14#issuecomment-1471202724, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFODTRWTTPWPWKUOQUFA6LW4J5QXANCNFSM6AAAAAAV25LMTQ . You are receiving this because you were mentioned.Message ID: @.***>

namandangi commented 1 year ago

@pearcetm the latest merge on main seems to be broken? The slide picker still doesn't function (should the slide picker work out of the box or is there something that needs to be done to set it up?) and the create home images also seems to have stopped working.

On checking logs, the home images were working fine at 4efece2. The browser console keeps throwing $().dialog/imageSelectionWindow.dialog is not a function

pearcetm commented 1 year ago

Reopened the issue. Will address much of the buggy behavior in an incoming PR.

.dialog is part of jqueryui. That is included in the packages.json and included in the HTML file as a script tag - you may have to update your packages.

pearcetm commented 1 year ago

@namandangi I think the biggest issue you were having is that jqueryui was missing. This was apparently preventing the script from creating the dialog window. If you update packages, it should automatically pull in what you need. If it doesn't, open a new issue and we can sort it out there.

There are more changes here as well (mostly under the hood). I had started on some further changes in my same branch after making the previous PR, which had broken the existing paper demo, so I fixed that up. It's working well for me as of now though.