dgutov / bmreplace

Quickly replace an existing bookmark in Mozilla Firefox
https://addons.mozilla.org/en-US/firefox/addon/bmreplace/
MIT License
24 stars 3 forks source link

Where is Menu item? #21

Closed BarbieBarb closed 10 years ago

BarbieBarb commented 10 years ago

Thankyou for this great ReplaceBookmark addon.

I have "Add the menu item" checked, but where is it and how is it supposed to perform? I expected to see it when I rightclick on webpage but I don't see it anywhere. Thankyou. http://i.imgur.com/UR0hjh7.png

NOTE: The icon is not in "Customize Toolbarbutton Storage Window" until after firefox restart.

Thankyou

dgutov commented 10 years ago

I have "Add the menu item" checked, but where is it and how is it supposed to perform?

It's in the main menu and in the bookmarks menu.

I expected to see it when I rightclick on webpage but I don't see it anywhere.

This is the first time anyone asked for it to be in the page context menu. I'll add a preference.

The icon is not in "Customize Toolbarbutton Storage Window" until after firefox restart.

Please describe the full scenario. What have you tried to do, and what did you see? Why would our icon be in the toolbar palette?

BarbieBarb commented 10 years ago

1. Oh yes I see "Add the menu item" now in Bookmarks Menu... in a clean testing profile. Can't remember if it was there before firefox restart but it is there after firefox restart. What main menu?... to me main menu is the rightclick on a webpage? http://i.imgur.com/rfDv0FK.png

3. WindowsVista Firefox26 Tested with clean profile with only 4other addons: Cookie Controller, Custom Buttons, Menu Editor, Stylish.

--Installed Replace Bookmarks. --It said it installed correctly. --Closed all tabs. --checked about:addons to see if it actually installed and it did. --closed all tabs. --Checked all toolbars to see if button appeared on any toolbars and it did not. --Checked "Customize Toolbarbutton Window Storage" and the button is not there. --Firefox restart. --ReplaceBookmark Button is in "Customize Toolbarbutton Window Storage".

dgutov commented 10 years ago

The main menu is usually in the top left corner of the application window. In Firefox on Windows, it's lately been replaced by the Orange Button (Replace Bookmark has a menu item there, too). See the two screenshots in the question here: http://askubuntu.com/questions/32395/can-i-change-the-firefox-menu-to-look-like-the-firefox-menu-in-windows

3....

Thanks, I'll take a look. But have you looked at the Browser Console? Do you see any errors there after Firefox just launched? It should be in Tools -> Web Developer -> Browser Console.

BarbieBarb commented 10 years ago

WindowsVista Firefox26

● Okay I see now. I have the Orange Button hidden. I use a custombutton that hides the titlebar. So I wasn't looking there. I clicked the Orange Button and see the ReplaceBookmark menuitem there. Firefox orange button > Bookmarks

● I am fairly new to github.com. I was clicking around and clicked on the Fork button to see what that was about. Did NOT intend to set up Fork... but don't know how to UNfork.

● Well I have the RepaceBookmarks Button appearing now so it doesn't matter to me now. I was just pointing it out to you.

--Uninstalled ReplaceBookmarks --Re-intalled ReplaceBookmarks --Checked "Customize Toolbarbuttons Storage Window" and there is NO ReplaceBookmarks button there. --Tools -> Web Developer -> Browser Console

WARN addons.xpi: Exception running bootstrap method startup on bmreplace@dgutov.github.com: TypeError: main.setLastVersion is not a function (resource://gre/modules/XPIProvider.jsm -> jar:file:///C:/Users/myusername/AppData/Roaming/Mozilla/Firefox/Profiles/hlqy0npf.TESTstylishcustomMOD/extensions/bmreplace@dgutov.github.com.xpi!/bootstrap.js:159)

http://img829.imageshack.us/img829/5126/x4gg.png

dgutov commented 10 years ago

see the ReplaceBookmark menuitem there. Firefox orange button > Bookmarks

That's how it should be, yes.

Did NOT intend to set up Fork... but don't know how to UNfork.

Not a problem. To "unfork", just delete the forked repository, it's in repository settings, see the wrench and screwdriver icon on the right.

TypeError: main.setLastVersion is not a function

Well, that's bad. Thanks for reporting this.

dgutov commented 10 years ago

I closed this after the fixing the startup error, but this extension still doesn't add an item to the context menu.

I wasn't sure if you wanted one, or if you just asked where the new menu items were. If you do want a context menu item, let me know, I'll see about adding one together with a new user preference.

BarbieBarb commented 10 years ago

I was just wondering where it was. I use the toolbarbutton for a quick one click. It is not needed for me so it is your choice to add it in Options for others or not.

Thankyou dgutov.

dgutov commented 10 years ago

Cool. No problem.