dgutov / bmreplace

Quickly replace an existing bookmark in Mozilla Firefox
https://addons.mozilla.org/en-US/firefox/addon/bmreplace/
MIT License
24 stars 3 forks source link

New update completely disabled add-on #44

Open speedytr opened 6 years ago

speedytr commented 6 years ago

With the update of v57 replace bookmark add-on completely disabled! are there any new versions coming? By the way love your add-on thx!

dgutov commented 6 years ago

As soon as I can set aside a couple days for this.

TBH, it's not a priority yet, because I can't use 57 day to day yet myself. Obviously, because of other addons :)

AHgPuK commented 6 years ago

Please, please make it worked on v57. A part of add-ons already do not work on v56. You need just to add permissions and that's it. I'm struggling without this wonderful add-on.

dgutov commented 6 years ago

You need just to add permissions and that's it.

Not sure what you mean.

AHgPuK commented 6 years ago

Not sure what you mean. In Firefox v57 they added a permissions management. That's why all add-ons are not compatible. Add it and we will enjoy again with your add-on. Thank you in advance.

dgutov commented 6 years ago

Could you paste some error from the Browser Console? Or a link to the description of the new permissions stuff? To get me started.

trlkly commented 6 years ago

It's not merely adding permissions. It requires completely rewriting the addon to work with Firefox 57 Beta or greater. You can use it in Firefox 57 Dev edition, but it requires enabling legacy addons in about:config. You need to set extensions.legacy.enabled to true.

Unfortunately, using the dev version will by default use a new profile, and you'll have to use "firefox.exe -P" to open your old one. And you'll need to either already have the addon downloaded, or download it "anyway" and then drag and drop to install it.

An easier solution is just to install Firefox 52 ESR. That will just work.

AHgPuK commented 6 years ago

Yes, you're right. I wrote my own "Replace bookmark" add-on with very similar behavior which is fully compatible with WebExtensions and Firefox 57 and works fine with prior versions as well. I used your code for a match grade calculation. Tell me if you have something against it. Thanks for your effort and the best bookmark maintainer add-on.

dgutov commented 6 years ago

@AHgPuK Do you have a link to the repository, and an xpi I can try out?

AHgPuK commented 6 years ago

Here is xpi: https://addons.mozilla.org/en-US/firefox/addon/replace-bookmark/ And source code: https://bitbucket.org/andreyh/replacebookmark/overview

dgutov commented 6 years ago

I used your code for a match grade calculation. Tell me if you have something against it.

That's totally fine. And I'm happy you made it.

I'd rather you used a different name, though, since it doesn't have all the same features, and I still might create a WebExtensions version of this addon. A different icon would be nice, too.

AHgPuK commented 6 years ago

OK. I'm done with changes. Now it is called "Update bookmark" and has my own icon.

dgutov commented 6 years ago

Thank you.

Note that in English titles (almost) all words are capitalized. If you do so, the name will be "Update Bookmark". There is an older addon with this name, but it seems to have been abandoned years ago.

trlkly commented 6 years ago

I would really appreciate it if any WebExtensions version was also made to run on Chrome. Though I do understand the barrier of paying $5 for the right to make extensions. (I get verifying your credit card to be sure you are who you say you are, but why not not refund the money after you've verified it?)

I am currently forced to use a Dev version of Chrome to have a Bookmark updating addon, as I had to modify an existing addon. I'd rather run release and avoid the Dev bugs.