search

dgutov / bmreplace

Quickly replace an existing bookmark in Mozilla Firefox
https://addons.mozilla.org/en-US/firefox/addon/bmreplace/
MIT License
24 stars 3 forks source link

Disappearing "Replace Bookmark" button #8

Closed ghost closed 12 years ago

ghost commented 12 years ago

Hello Sir!

How to reproduce the disappearing button:

  1. Hide the Menu bar
  2. Drag the Bookmarks button (the one with the drop-down arrow) from Customize menu onto the bar - between Navigation toolbar (Address bar) and Search bar
  3. Click on the Bookmarks button. Replace Bookmark button should be visible.
  4. Unhide Menu Bar
  5. Click on the Bookmarks Menu (between History and Tools). Replace Bookmark button should be visible.
  6. Right Mouse click on a bar and select Customize...
  7. Drag the Bookmarks button away from the tab inside the Customize Toolbar windows
  8. Restart Firefox
  9. Click on the Bookmarks button. Replace Bookmark button is not visible.
  10. Hide the Menu bar
  11. Drag the Bookmarks button (the one with the drop-down arrow) from Customize menu onto the bar - between Navigation toolbar (Address bar) and Search bar
  12. Click on the Bookmarks Menu (between History and Tools). Replace Bookmark button is not visible. And it also messes up userchrome.css tweaks.
dgutov commented 12 years ago

Thanks for the report, I think I see the problem.

And it also messes up userchrome.css tweaks.

Could you give an example?

ghost commented 12 years ago

Hi again!

These are the userChrome.css tweaks i'm using to hide some things i don't need when pressing Bookmarks button:

BMB_viewBookmarksToolbar { display: none !important; }

BMB_viewBookmarksToolbar + menuseparator { display: none !important; }

BMB_bookmarksShowAll + menuseparator { display: none !important; }

BMB_subscribeToPageMenuitem { display: none !important; }

BMB_subscribeToPageMenupopup { display: none !important; }

BMB_subscribeToPageMenupopup + menuseparator { display: none !important; }

BMB_bookmarksToolbar { display: none !important; }

BMB_bookmarksToolbar + menuseparator { display: none !important; }

BMB_bookmarksPopup menuseparator:nth-last-child(2) { display: none !important; }

BMB_unsortedBookmarks { display: none !important; }

They hide all things and leave visible only: Show All Bookmarks, Bookmark This Page and Separator (after the separator are the bookmarked sites).

It looks like this:

Show All Bookmarks Bookmark This Page Replace Bookmark ----------------------------(Separator, straight line) ...bookmarked sites...

When you reproduce steps for disappearing Replace Bookmarks button, it looks like this:

Show All Bookmarks Bookmark This Page ...bookmarked sites...

Notice that Separator and Replace Bookmark button are missing. Restarting Firefox shows (displays) userChrome.css tweaks again correctly.

ghost commented 12 years ago

Also, i don't know if i'm gonna use Replace Bookmark option accessible through Firefox button and then expanding Bookmarks menu.

I just mentioned it since i thought that possibility, imho, should be covered too for some other users how might be using it.

dgutov commented 12 years ago

Hello, Josey!

Thanks for the big description. I'll upload a fixed version soon.

The missing separator is to be expected. With "Replace Bookmark" menu item absent,

#BMB_subscribeToPageMenupopup + menuseparator { display: none !important; }

matches against the separator and hides it. I think it's normally unused.