diff-hl-dired-mode does not respect diff-hl-draw-borders

[semente]

When diff-hl-draw-borders is nil, I still see borders on dired buffers

[dgutov]

Could you post a screenshot? I suspect that by borders, we mean different things.

[semente]

There we go:

[dgutov]

Are you sure you're using the latest version (1.5.1)? My dired buffers look quite different:

[semente]

Yes, I also found strange that these chars (|, ? and +) is not showing up - it works only when the margin mode is enabled.

I've installed it from Marmalade.

[dgutov]

Marmalade only has a fairly old, single-file version: http://marmalade-repo.org/packages/diff-hl I don't see how you could have diff-hl-dired-mode from there.

Did you install from GNU ELPA, maybe? It has the latest version.

So, do you have 1.5.1? What line(s) do you have in the init file to set it up?

[semente]

Yep, it was downloaded from GNU ELPA. Just thought I got it from Marmalade...

There is my customizations:

 '(diff-hl-draw-borders nil)
 '(dired-mode-hook (quote (dired-extra-startup diff-hl-dired-mode)))
 '(global-diff-hl-mode t)

[dgutov]

Sorry, I can't reproduce it (even when the modes are enabled via the custom file, like in your example).

Please try looking if you have an older version of diff-hl lying around, then try reinstalling the package, and if that fails, try starting from emacs -Q to reproduce this.

[dgutov]

What's your Emacs version, by the way?

[semente]

It is GNU Emacs 24.3.50.1.

But you are right, it happens only with my Emacs... starting with -Q works fine. Sorry for not have tried it before.

Anyway, I find quite strange working with -Q. I've managed it to work now using the Git files. Give a look on the diff:

diff /tmp/diff-hl/diff-hl-dired.el elpa/diff-hl-1.5.1/diff-hl-dired.el
30,31d29
< (defvar diff-hl-dired-process-buffer nil)
< 
43a42,43
> (defvar diff-hl-dired-process-buffer nil)
> 
62c62
<          (lambda (entries &optional _more-to-come)
---
>          (lambda (entries &optional more-to-come)

diff /tmp/diff-hl/diff-hl.el elpa/diff-hl-1.5.1/diff-hl.el
170c170
< (defun diff-hl-fringe-bmp-from-pos (_type pos)
---
> (defun diff-hl-fringe-bmp-from-pos (type pos)
173c173
< (defun diff-hl-fringe-bmp-from-type (type _pos)
---
> (defun diff-hl-fringe-bmp-from-type (type pos)
177,178d176
< 
< (defvar vc-svn-diff-switches)

[dgutov]

It is GNU Emacs 24.3.50.1.

It's Emacs trunk, then? Just the version I'm using. You might want to try updating it, if you haven't already.

Anyway, I find quite strange working with -Q.

The idea is to then restore pieces of your configuration one by one (or do a binary search of sorts, manually), to find out which one creates the problem.

Give a look on the diff:

This looks just like the last commit I made today to fix some byte-compilation warnings. Are you sure it makes any difference (you can try git checkout HEAD^ in the local repo clone)?

[dgutov]

@semente Any news?

[semente]

Hello @dgutov, it seems working fine now... I didn't nothing, but I got some Emacs updates recently. I can't be sure if was that what fixed, sorry, there is long time since I got this problem. I was traveling and couldn't give too much attention to this.

Thank you and sorry for disturbing you again with a "ghost bug"! :-)

[dgutov]

That's no trouble, glad it's working now.