search

dgutov / diff-hl

Emacs package for highlighting uncommitted changes
GNU General Public License v3.0
914 stars 44 forks source link

Startup dependency issue #181

Closed Ergus closed 2 years ago

Ergus commented 2 years ago

Hi:

I installed from elpa and I am getting this error: (void-function smartrep-define-key)

It seems like smartrep is not declared as a dependency for melpa. I think that with the new repeat-mode this may be unneeded, because the package seems to be also unmaintained (last commit was in 2015)... but probably you want to keep it compatible with the old emacs versions, so any solution you choose (remove the dependency code or add the package as a dependency) may be fine IMO

dgutov commented 2 years ago

Hi!

The only call to smartrep-define-key happens inside a block predicated on (when (require 'smartrep nil t) ...).

Any idea why it happens on your machine? Is it possible that you have smartrep actually installed, but some incomplete version of it?

Ergus commented 2 years ago

Another package was adding an advise to my require function... now solved