search

dgutov / robe

Code navigation, documentation lookup and completion for Ruby
584 stars 37 forks source link

Let Robe start in virtual environment #100

Closed aki2o closed 5 years ago

aki2o commented 7 years ago

I'm developing using docker. So, it requires that robe starts in docker container as virtual environment. Therefore, robe has to receive a host option for starting server.

We'll be able to develop using robe under docker container from this patch and docker-robe.el.

dgutov commented 7 years ago

Please see the branch allow-to-specify-host. Does it work okay for your purpose?

dgutov commented 7 years ago

@aki2o Ping.

mvgijssel commented 6 years ago

Please see the branch allow-to-specify-host. Does it work okay for your purpose?

I'm currently using your branch and it works perfectly! My development environment runs in Docker and I use "binstubs", direnv and exec-path-from-shell to forward calls to running containers.

Would it be possible to merge your branch into master and update the elpa package?

dgutov commented 6 years ago

@mvgijssel Sure. But first, could you describe in a bit more detail how you are making use of it?

mvgijssel commented 6 years ago

Sure! If have a file called bundle in my path (due to direnv) which looks like:

#!/bin/sh
docker-compose exec -T web bundle "$@"

When robe-start is called bundle exec rails console development is run, which is executed in the docker container. robe-request then sends a request to the configured port and host (on your branch), which will be the docker container running the robe server.

dgutov commented 5 years ago

@mvgijssel Sorry for the slow reaction, but it should work now.

Regarding docker-compose, clever solution. As far as Docker support is concerned, I was thinking instead in the direction of SSH-ish into the container using Tramp and running the REPL buffer from there manually.

dgutov commented 5 years ago

@mvgijssel Do you use direnv instead of rbenv as well? Does it need explicit Emacs integration?