search

dgutov / robe

Code navigation, documentation lookup and completion for Ruby
584 stars 37 forks source link

Document webrick dependency in ruby 3 #129

Closed yourpalal closed 3 years ago

yourpalal commented 3 years ago

In ruby 3.0.0, webrick has been removed from the standard library. This means that it must be added to your Gemfile in order to use robe in a ruby 3.0.0 project.

Once webrick is installed, everything seems to work well!

dgutov commented 3 years ago

Yes, thanks the taking the initiative on this.

I've been thinking whether we can drop it and reimplement request-response parsing and serialization without webrick, but didn't have the time to look into it yet.

mjhoy commented 2 years ago

@dgutov Any updates on "I've been thinking whether we can drop it and reimplement request-response parsing and serialization without webrick"? I'd be happy to take a look at it as well.

dgutov commented 2 years ago

@mjhoy Hi! Please try the latest master.

It's a smaller change than I was thinking previously, but it reaches the main goal.

To drop HTTP entirely, I'd have to hand-write a different client on Emacs's side than url-http. Might still be worth it, though.

mjhoy commented 2 years ago

That fixes the issue for me, thanks.