dgw / plex-pushover

A simple plex webhook to send a Pushover notification every time someone starts playing media on your server
MIT License
5 stars 3 forks source link

Code/style cleanup #14

Open dgw opened 6 years ago

dgw commented 6 years ago

Main things:

This is partly complete in my local copy, but I need to rebase it on top of current master and probably play with eslint.

dgw commented 6 years ago

Working on this is both good fun (learning about eslint rules) and incredibly frustrating (some rules do things that are just not quite what I'd like).

But I learned today that const doesn't mean "immutable"—a good thing to learn early in my ES6 journey. Seems plenty of ES6 developers think it does, but you can modify a const object's properties all you like. It's just not possible to rebind the name to something else in that scope, which is good. (Hey, I work on stuff like this to learn, so "fixing" this issue is working out exactly as intended.)