dgw / sopel-BombBot

Customized version of a custom version of a bomb module for Sopel
2 stars 1 forks source link

Module doesn't ignore the bot properly #16

Closed dgw closed 8 years ago

dgw commented 8 years ago

Example:

<dgw> Kaede: literal ;cutwire red
<Kaede> ;cutwire red (=> !cutwire red) (#1138) <reply> <AlexLykos> it's never
        the red wire (#1272) <reply> <Steinr> it's always the red wire
<Kaede> KeyError: u'kaede' (file "/var/lib/willie/modules/bombbot.py",
        line 175, in cutwire)

Not an issue under normal circumstances, but it shouldn't be possible anyway.

Comes down to line 164 (in current master):

        if target.lower() != bot.nick.lower() and target.lower() not in BOMBS:
dgw commented 8 years ago

Reopen if other commands need this check. We shall see.

Ideally this would be taken care of in sopel core, I guess.