search

dgw / sopel-BombBot

Customized version of a custom version of a bomb module for Sopel
2 stars 1 forks source link

Nicks containing | break .bombcancel #24

Closed dgw closed 8 years ago

dgw commented 8 years ago

Discovered by accident, when I bombed the wrong nickname by mistake (timestamps to show the fuse hadn't expired):

[13:42:44] <dgw> ;bomb Senna|interview
[13:42:46] <Kaede> Senna|interview, I just saw someone put a bomb down your pants! There
                   are 4 wires (Red, White, Black and Orange), and I think it's a 2 minute
                   fuse. Quick, tell me what wire to cut! (respond with ;cutwire color)
[13:42:46] <dgw> fug
[13:42:49] <dgw> ;bombcancel Senna|interview
[13:42:50] <Kaede> dgw: There is no bomb on Senna|interview.

Confirmed the issue in testing:

[13:50:58] <dgw> ;bomb dgw|test
[13:50:58] <Kaede> dgw|test, I just saw someone put a bomb down your pants! There are
                   4 wires (Green, Yellow, White and Pink), and I think it's a 2 minute
                   fuse. Quick, tell me what wire to cut! (respond with ;cutwire color)
[13:51:02] <dgw> ;bombcancel dgw|test
[13:51:03] <Kaede> dgw: There is no bomb on dgw|test.
[13:51:06] <dgw> o rly

Probably something to do with a missing cast to Identifier or forgotten .lower().