search

dgw / sopel-duel

Clone of a mIRC script that lets users duel each other
1 stars 1 forks source link

Loophole in .dueloff post-duel cooldown #33

Closed dgw closed 7 years ago

dgw commented 8 years ago

Like BombBot's .bomboff had a loophole where doing .bomboff mynick could bypass the cooldown (see dgw/sopel-BombBot#28), so does .dueloff have the same problem.

The fix should be as simple as aping the changes in dgw/sopel-BombBot#29 and testing the result for a few days before merging to master.

dgw commented 7 years ago

Oops, I was careless with my wording in #38 and it closed this issue prematurely.

dgw commented 7 years ago

And once again, I left a silly thing in a commit that references an issue, and had to force-push an amended commit, thus referencing the issue again.

Someday I'll git gud at this SCM thing.