search

dgw / sopel-wolfram

Wolfram|Alpha plugin for the Sopel IRC framework
Other
5 stars 1 forks source link

Add support for wolframalpha 3.0 #11

Closed dgw closed 7 years ago

dgw commented 7 years ago

Allow pip to satisfy the requirement with any version between 2.0 (inclusive) and 4.0 (exclusive).

Some queries have different output when using 3.0 (vs. when using 2.x), but in most cases it appears that the change is from returning "No text-representable result" to returning some form of usable text, so I won't spend a ton of time trying to figure out why. It's an improvement.

Completes part all (revised May 10, 2017) of #5 (supporting both 2.x and 3.x).

dgw commented 7 years ago

As of 57d088b, this is working with wolframalpha both 2.4 and 3.0. However, there are some regressions in certain cases that concern me. Under 3.0, for example, .wa dgw returns an error ("No text-representable result"). It should, however, return information about the Converse County Airport in Wyoming.

This should not be merged without first finding and fixing the source of these regressions.

dgw commented 7 years ago

Removing do not merge label, as the regression appears to be fixed by a5c63aa. Still not truly ready to merge because of pending refactoring/cleanup, but nothing should break now.