search

dgxvolume / dgxvolume.github.io

Website that displays DGX volume data
2 stars 0 forks source link

Wrong address for recast fee collection account #1

Open veox opened 5 years ago

veox commented 5 years ago

Currently there's:

https://github.com/dgxvolume/dgxvolume.github.io/blob/f8e305f87328041fb71839182b613ad560d3aa7b/scripts/addressbook.py#L4

If I understand correctly, 0x2a0e..efdb is the "recast" no-code contract that collects fees, not the one above.

Take for example the most recent "recast" transaction, on May-14-2019 08:14:46 AM +UTC. It sends 100 DGX to 0x0000..0000, and 1 DGX to 0x2a0e..efdb. (Technically, 1% extra.)

It can also be seen in the deployment tx for the other no-code fee collection contracts, among which is 0x00a5..4617 - properly listed as the "transfer fee" collector:

https://github.com/dgxvolume/dgxvolume.github.io/blob/f8e305f87328041fb71839182b613ad560d3aa7b/scripts/addressbook.py#L2

I'm currently trying to look up what this 0x26ca..7f68 is - I'd idly guess it's some sort of controller, but haven't found which yet, since there are so many...

veox commented 5 years ago

The 0x26ca..7f68 address is the one returned by get_contract() for i:popadmin on the DGX token. You can check that on EtherScan's "read contract" tab relatively easily.