Use "read_text()" so the file handler will be closed

dgzlopes / cloud-detect

Module that determines a host's cloud provider.

https://pypi.org/project/cloud-detect/

MIT License

35 stars 13 forks source link

Closed arossert closed 2 years ago

arossert commented 2 years ago

Addressing #13

arossert commented 2 years ago

@kshivakumar Can you please review?

arossert commented 2 years ago

@kshivakumar Following step 4 in the "How to contribute" (bug me until it gets merged and published.) 😃 Can we get this published?

arossert commented 2 years ago

@dgzlopes Can you please merge?

arossert commented 2 years ago

@dgzlopes can you please look at this one?

arossert commented 2 years ago

@dgzlopes any chance this can be merged?

dgzlopes commented 2 years ago

Sorry for the delay :(

I had some vacations. Let me merge it and cut a new release. Thanks for the work!

arossert commented 2 years ago

Thanks for the merge