Improve AWS detection - Githubissues

dgzlopes / cloud-detect

Module that determines a host's cloud provider.

https://pypi.org/project/cloud-detect/

MIT License

35 stars 13 forks source link

Improve AWS detection #17

Closed arossert closed 2 years ago

arossert commented 2 years ago

To improve AWS detection I did 2 things

Using response.json(content_type=None) - in some cases the metadata API returns Content-Type header of text/plain which cause this function to fail unless you tell it to ignore it.
Checking /sys/class/dmi/id/bios_vendor file - added the ability to call check_vendor_file multiple time in the same Provider class.

arossert commented 2 years ago

@kshivakumar @dgzlopes This change is a bit bigger than I initially intended, if you have other ideas for implementation I will be happy to make the changes

arossert commented 2 years ago

@kshivakumar @dgzlopes Seems like I have the same issue on Windows machines, can you please review this change? 🙏

arossert commented 2 years ago

Currently I'm using this workaround

import aiohttp
from functools import partialmethod

aiohttp.ClientResponse.json = partialmethod(aiohttp.ClientResponse.json, content_type=None)

arossert commented 2 years ago

@kshivakumar Thanks for reviewing, I was conflicted if doing this by converting the vendor_file to a iterable is better design 😃 If you think it is better I can make the change.

arossert commented 2 years ago

I can also add the typo fix (#19) to this one

arossert commented 2 years ago

@kshivakumar @dgzlopes can you please review this one?

arossert commented 2 years ago

@dgzlopes Please, I need this fix for my project, can you review and merge 🙏

arossert commented 2 years ago

Thanks for merging 💪🏻