search

dgzlopes / cloud-detect

Module that determines a host's cloud provider.
https://pypi.org/project/cloud-detect/
MIT License
35 stars 13 forks source link

Add Alibaba cloud provider #2

Closed dgzlopes closed 3 years ago

dgzlopes commented 3 years ago

Determine if the host cloud provider is Alibaba.

You can see how we detect the other providers (e.g AWS) here.

For reference, you can check banzaicloud/satellite code.

nmaltais commented 3 years ago

I'll give this issue a go!

rhyspowell commented 3 years ago

Just dropped the PR in, should have possibly called it out earlier I was working on. Looks like tests are failing due to changes in pip that started today. Will see if I can resolve that in the branch #5

rhyspowell commented 3 years ago

PR #5 Is now good to look at, failing test is on one that I think you are happy with. Let me know if there is anything to fix