search

dgzlopes / cloud-detect

Module that determines a host's cloud provider.
https://pypi.org/project/cloud-detect/
MIT License
35 stars 13 forks source link

Fix AWS detection #20

Closed arossert closed 2 years ago

arossert commented 2 years ago

Handling #15, In some cases, AWS metadata returns Content-Type: text/plain

arossert commented 2 years ago

@dgzlopes I would really appreciate it if you can merge this one. I need this fix for my use-case 🙏

kshivakumar commented 2 years ago

@arossert Your other PR https://github.com/dgzlopes/cloud-detect/pull/17 already takes care of this. The other "vendor_file" related changes are not substantial, at least logically. Reviewing and merging that PR should be suffice as long as test cases are passing.

arossert commented 2 years ago

@kshivakumar I know that this PR is covered by #17, but since this change is more important to me and the other PR was not reviewed for a while I assumed it is too big of a change, so I extracted this one, if the other PR will be accepted I can close this one.

dgzlopes commented 2 years ago

Let's close this in favor of #17

Thanks again for the contribution, and sorry again for my delays!