search

dgzlopes / cloud-detect

Module that determines a host's cloud provider.
https://pypi.org/project/cloud-detect/
MIT License
35 stars 13 forks source link

Azure false positive fix for vultr, separate build config for Python 3.6, add support for 3.10 and 3.11 #24

Closed derekjc closed 1 year ago

derekjc commented 1 year ago

Checking for specific response in azure metadata response is more reliable.

Closes #23

kshivakumar commented 1 year ago

@derekjc Python 3.6 build is failing due to https://github.com/actions/setup-python/issues/561. Some changes are required in tox.ini to fix it on our side. I will look into it in couple of days.

Although we could drop support for 3.6 as it reached end-of-life in Dec 2021, there are considerable no. of users. We should support it for few more years.

kshivakumar commented 1 year ago

~@derekjc Can you add please add Python 3.10 and 3.11 here - https://github.com/dgzlopes/cloud-detect/blob/23fa390d74d7ee435801105f29f625a2ac4907bc/setup.py#L34~

Never mind, you did that already.

kshivakumar commented 1 year ago

Thanks for the PR @derekjc, I will make a release soon.