search

dgzlopes / cloud-detect

Module that determines a host's cloud provider.
https://pypi.org/project/cloud-detect/
MIT License
35 stars 13 forks source link

Migrate from TravisCI to Github actions #3

Closed dgzlopes closed 3 years ago

dgzlopes commented 3 years ago

You can use the existing .travis.yaml as a reference. Also, the badge on the readme needs to be changed.

Arsh25 commented 3 years ago

I am currently working on this. Python 3.4 is now EOL. Do you still intend to support it? Currently, Python 3.4 does not work since PyYAML does not support it. This is a dependency inherited from Tox. Current progress can be tracked in my fork

Actually, it looks like Tox dropped 3.4 support too. So 3.4 will not be able to be tested with the current testing strategy.

dgzlopes commented 3 years ago

Thanks a lot for working on this!

It's OK to stop supporting Python 3.4 from my pov. Also, maybe we should test/add some newer Python versions.

Arsh25 commented 3 years ago

I can add more. There is a weird error with Python 3.5 not being able to find the README.md in setup.py, This may need to be tracked in another issue but I pushed a temporary fix on my fork. Let me know if this is ok for now otherwise I will try and find an actual fix before opening a PR

dgzlopes commented 3 years ago

We can skip 3.5 too if needed. I don't know of anyone running this with Python<3.6.

So, if it's an issue, we can remove it :)

There is no need to maintain compatibility with tons of versions!

Arsh25 commented 3 years ago

eh, I worked around it