dh-tech / undate-python

A Python library for working with fuzzy, partial, or otherwise uncertain dates
Apache License 2.0
8 stars 1 forks source link

integrate numpy datetime64 for greater range of years #77

Closed rlskoeser closed 1 week ago

rlskoeser commented 5 months ago

benchmarking / documentation:

rlskoeser commented 4 months ago

next steps:

rlskoeser commented 4 months ago

From NumPy installation docs:

NumPy doesn’t depend on any other Python packages, however, it does depend on an accelerated linear algebra library - typically Intel MKL or OpenBLAS. Users don’t have to worry about installing those (they’re automatically included in all NumPy install methods)

rlskoeser commented 2 weeks ago

@ColeDCrawford as I close this out, I remembered you wanted some benchmarking / assessment on the numpy inclusion. The test suite is pretty fast either way, and we've also been expanding the functionality in other ways, so it's not a strict comparison.

Running a checkout of the 0.2 tag, I get

113 passed in 0.11s

Running in current develop, I get

138 passed in 0.16s

I compared the virtualenv size when installing version 0.2 and current develop. Without numpy, the virtualenv is 14MB; with numpy it's 46MB. Looking at the folders in the sitep ackages for the latter, the numpy folder is 31MB on its own.

Let me know if you think any of this needs to be documented in the changelog or elsewhere.

ColeDCrawford commented 2 weeks ago

Nice, thanks for remembering that. Seems like a negligible performance difference with the main change being the payload size, but we knew about that going in. I think it would be nice to note in the changelog for the v1.0 release