Closed rlskoeser closed 2 weeks ago
@coderabbitai full review
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Think this will need to be updated with the #84 changes?
It is branched off from that but will probably need to be updated, they may have diverged by now. I'll update this one after the big numpy refactor is finally merged into develop.
This adds glue between undate and the existing EDTF parsing by adding a date formatter class. The parse method simply uses the parser and transformer; the to string method uses custom logic because I couldn't figure out an elegant way to leverage the parsing code (there's a reconstruct method but the tree is pretty complicated).
I also added support for parsing and formatting 5+ digit years now that we support it (this is based on the numpy code in #84 ).