dh1tw / remoteRotator

remoteRotator lets you expose a local antenna rotator (azimuth / elevation) to the network
MIT License
44 stars 5 forks source link

elevation-max setting in config file is ignored #21

Open Void-Seeker opened 2 years ago

Void-Seeker commented 2 years ago

My config file contains elevation-max = 90 setting, but remoteRotator interface still draws 180 degrees gauge and allows to select elevation more than 90 degrees.

dh1tw commented 2 years ago

Hi @Void-Seeker, can you provide your complete config file?

At least on the remoteRotator playground elevation-min and elevation-max work as expected (check the UHF rotator). Here is the config file of that (dummy) rotator.

Void-Seeker commented 2 years ago

Here it is, with proof screenshot. Current antenna elevation is beyond green zone. I've just commanded it to go there through remoteRotator. vhf.toml.txt

image

dh1tw commented 2 years ago

ok - thanks. That helps. Just to make sure - which version of remoteRotator are you using? Please send us the output of remoteRotator version. Which browser and version are you using? How did you actually command the elevation to go about elevation-max? By clicking on the Web Interface, manually moving the rotator or maybe the telnet interface?

Void-Seeker commented 2 years ago

Server:

uname -a
Linux <redacted> 5.10.0-9-amd64 #1 SMP Debian 5.10.70-1 (2021-09-30) x86_64 GNU/Linux
remoteRotator version
copyright Tobias Wellnitz, DH1TW, 2020
remoteRotator Version: v0.6.2, linux/amd64, BuildDate: 2021-12-17T09:23:52+02:00, Commit: bcb3d46

Client:

uname -a
Linux <redacted> 5.4.0-91-generic #102-Ubuntu SMP Fri Nov 5 16:31:28 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
firefox --version
Mozilla Firefox 95.0

Also tried that on Windows 10, also with recent firefox.

I've commanded the rotator through the browser. Also tried to wipe browser cache.

I can provide a link for the working setup, but be careful as they are real antennas, and too high elevation puts too much stress to the cables (the reason why I want to restrict it). In fact, that cable is actually already broken, we will repair it when possible, but that may take a while.

ea4tx commented 2 years ago

What is the interface to control the rotator you use? In my opinion, it is your interface control software that should limit elevation to the 90º you want to use. I do not see logic that the interface reports that it is at 106º and the remoteRotator changes it to 90 because you have defined the "elevation-max = 90"

73s Pablo EA4TX

Void-Seeker commented 2 years ago

What is the interface to control the rotator you use? In my opinion, it is your interface control software that should limit elevation to the 90º you want to use. I do not see logic that the interface reports that it is at 106º and the remoteRotator changes it to 90 because you have defined the "elevation-max = 90"

73s Pablo EA4TX

I'm not talking about what sensor reports, I'm talking about remoteRotator delivering out-of-operational-range command to the interface. That should not happen. But I agree it also should be limited in hardware.

I believe UHF rotator hardware is one of yours design. It wasn't me who configured it tho. I'm more of just a system administrator there.

dh1tw commented 2 years ago

Thanks for the additional information. This seems to be a browser-related issue. With Chrome the Web UI works as expected, while Firefox lets us indeed select values above elevation-max and below elevation-min.

I will fix it with the next release.

I also agree with Pablo. You should never rely on remoteRotator for enforcing limits. This should always be done either in the Rotator controller or a mechanical way.

Do yourself a favor and remove the link to your instance of remoteRotator. You should never expose a remoteRotator instance unprotected to the public Internet. In the WIki you can find an article on how to properly expose remoteRotator to the internet in a secure way.

Void-Seeker commented 2 years ago

Thanks for the additional information. This seems to be a browser-related issue. With Chrome the Web UI works as expected, while Firefox lets us indeed select values above elevation-max and below elevation-min.

I will fix it with the next release.

I also agree with Pablo. You should never rely on remoteRotator for enforcing limits. This should always be done either in the Rotator controller or a mechanical way.

Do yourself a favor and remove the link to your instance of remoteRotator. You should never expose a remoteRotator instance unprotected to the public Internet. In the WIki you can find an article on how to properly expose remoteRotator to the internet in a secure way.

Thank you for security reminder, but I'm aware about password protection and all that Caddy stuff. It is left unprotected for a reason, as it is a part of public WEBSDR server and is intended to be accessed by anyone, at least for now.

Void-Seeker commented 2 years ago

Thanks for the additional information. This seems to be a browser-related issue. With Chrome the Web UI works as expected, while Firefox lets us indeed select values above elevation-max and below elevation-min.

I will fix it with the next release.

I also agree with Pablo. You should never rely on remoteRotator for enforcing limits. This should always be done either in the Rotator controller or a mechanical way.

Do yourself a favor and remove the link to your instance of remoteRotator. You should never expose a remoteRotator instance unprotected to the public Internet. In the WIki you can find an article on how to properly expose remoteRotator to the internet in a secure way.

By the way, that tutorial is not working for Caddy v2.

dh1tw commented 2 years ago

Thanks @Void-Seeker, indeed there are some breaking changes in the syntax between caddy v1 and caddy v2. I just updated the tutorial to the caddy v2 syntax.

dh1tw commented 2 years ago

fixed with ed4fbc7. Will be included in the next release.

Void-Seeker commented 2 years ago

@dh1tw I've built and installed commit ed4fbc7 on our server today, and users started to note that it no longer responds to the clicks(and taps), only to drag. Is this intended behavior, or bug?

dh1tw commented 2 years ago

Indeed - That's a regression bug. I will fix it.