dh4 / mupen64plus-qt

A customizable launcher for Mupen64Plus
BSD 3-Clause "New" or "Revised" License
95 stars 10 forks source link

Error building rpm #29

Closed john-cheesman closed 7 years ago

john-cheesman commented 7 years ago

Hi,

I'm trying to build an rpm following the instructions in the readme but I'm getting a C++ error where it can't find the quazip header file.

Getting https://github.com/dh4/mupen64plus-qt/archive/1.10.tar.gz to /home/john/rpmbuild/SOURCES/1.10.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   124    0   124    0     0    165      0 --:--:-- --:--:-- --:--:--   165
100  117k  100  117k    0     0  72194      0  0:00:01  0:00:01 --:--:--  179k
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.TzGCIz
+ umask 022
+ cd /home/john/rpmbuild/BUILD
+ cd /home/john/rpmbuild/BUILD
+ rm -rf mupen64plus-qt-1.10
+ /usr/bin/gzip -dc /home/john/rpmbuild/SOURCES/1.10.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd mupen64plus-qt-1.10
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.0g0JI3
+ umask 022
+ cd /home/john/rpmbuild/BUILD
+ cd mupen64plus-qt-1.10
+ sed -i 's#include <quazip/#include <quazip5/#g' src/common.h
+ qmake-qt5
+ make -j2
/usr/lib64/qt5/bin/uic src/dialogs/gamesettingsdialog.ui -o ui_gamesettingsdialog.h
/usr/lib64/qt5/bin/uic src/dialogs/settingsdialog.ui -o ui_settingsdialog.h
g++ -c -pipe -O2 -Wall -W -D_REENTRANT -fPIC -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_XML_LIB -DQT_SQL_LIB -DQT_CORE_LIB -I. -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtXml -isystem /usr/include/qt5/QtSql -isystem /usr/include/qt5/QtCore -I. -I. -I/usr/lib64/qt5/mkspecs/linux-g++ -o main.o src/main.cpp
g++ -c -pipe -O2 -Wall -W -D_REENTRANT -fPIC -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_XML_LIB -DQT_SQL_LIB -DQT_CORE_LIB -I. -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtXml -isystem /usr/include/qt5/QtSql -isystem /usr/include/qt5/QtCore -I. -I. -I/usr/lib64/qt5/mkspecs/linux-g++ -o common.o src/common.cpp
src/common.cpp:43:27: fatal error: quazip/quazip.h: No such file or directory
 #include <quazip/quazip.h>
                           ^
compilation terminated.
Makefile:492: recipe for target 'common.o' failed
make: *** [common.o] Error 1
make: *** Waiting for unfinished jobs....
error: Bad exit status from /var/tmp/rpm-tmp.0g0JI3 (%build)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.0g0JI3 (%build)

I installed the dependencies before. This is on Fedora 24 x86_64

Thanks

dh4 commented 7 years ago

Does it build if you change the %build section in the spec file from this:

%build
sed -i 's#include <quazip/#include <quazip5/#g' src/common.h

To this:

%build
sed -i 's#include <quazip/#include <quazip5/#g' src/common.cpp
sed -i 's#include <quazip/#include <quazip5/#g' src/emulation/emulatorhandler.cpp

If so, I'll update the spec file. Looks like I moved some things around and forgot to update the Redhat package files.