dhairyagothi / 100_days_100_web_project

This repository contains 100 web projects from basic to intermediate using html css and js Please star the repo before start working on it
https://50-days-50-web-project.vercel.app/
MIT License
30 stars 36 forks source link

Movie Search engine #147

Closed MonishRaman closed 4 months ago

MonishRaman commented 4 months ago

Related Issue: #130

[Cite any related issue(s) this pull request addresses. If none, simply state "None”] write issue no. here

Email id used to regsiter for VSoc'24: monishr608@gmail.com

Description

[Please include a brief description of the changes or features added]

Type of PR

check in issue by entering [X] in boxes

Screenshots / Videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist

check in issue by entering [X] in boxes

Additional Context

[Include any additional information or context that might be helpful for reviewers.]

Contribution Guidelines

Thank you for considering contributing to our project! To ensure smooth collaboration and effective contribution management, please adhere to the following guidelines:

Issue Creation

  1. Limit on Issues:
    • Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.

Contribution Levels

  1. Basic Contributions:

    • This project is primarily focused on documentation. Most of the setup has been completed, so contributors will generally need to work on basic code tasks, such as writing tests.
    • For these tasks, issues will be assigned the Easy label.
  2. Acknowledging Hard Work:

    • If a contributor puts in significant effort on a task, the issue will be upgraded to Medium. This is our way of recognizing and appreciating extra effort.
  3. Feature Additions and Component Work:

    • Contributors working on new features or components using JSX/TSX will be assigned a level based on the complexity and quality of their work.
    • The more complex and valuable the contribution, the higher the level assigned.

Level Definitions

We look forward to your contributions and appreciate your effort in helping us improve the project!

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
50-days-50-web-project ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 0:23am
github-actions[bot] commented 4 months ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

gitguardian[bot] commented 4 months ago

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/workspace/517130/incidents/secrets) | | Generic High Entropy Secret | d09747dfa3a34f4257cab71a4f2f231348577e9a | public/movie search/script.js | [View secret](https://github.com/dhairyagothi/50_days_50_web_project/commit/d09747dfa3a34f4257cab71a4f2f231348577e9a#diff-48a6c64ddf24c2f3256df8eefe2e34e7657c63359ed9f7ae3401fec64381c50fR1) | | [-](https://dashboard.gitguardian.com/workspace/517130/incidents/secrets) | | Generic High Entropy Secret | 38d665ae4b50e59f4738af20207d7099fb5653dc | public/movie_search/script.js | [View secret](https://github.com/dhairyagothi/50_days_50_web_project/commit/38d665ae4b50e59f4738af20207d7099fb5653dc#diff-e06b0ade5c06c78ef119abb434f584419d9b8a58262645e8c976b694c4c32c1aL1) | | [-](https://dashboard.gitguardian.com/workspace/517130/incidents/secrets) | | Generic High Entropy Secret | d09747dfa3a34f4257cab71a4f2f231348577e9a | public/movie search/script.js | [View secret](https://github.com/dhairyagothi/50_days_50_web_project/commit/d09747dfa3a34f4257cab71a4f2f231348577e9a#diff-48a6c64ddf24c2f3256df8eefe2e34e7657c63359ed9f7ae3401fec64381c50fL1) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

dhairyagothi commented 4 months ago

nahi chal rahi abhi bhi kuch api key h kya isme ??

MonishRaman commented 4 months ago

in other device also i tried its working

MonishRaman commented 4 months ago

don't know y its not working there

MonishRaman commented 4 months ago

i think bcz of that security error its showing

MonishRaman commented 4 months ago

yes there is a api key in js file

dhairyagothi commented 4 months ago

yes there is a api key in js file

share ss of code where it is

MonishRaman commented 4 months ago

image

dhairyagothi commented 4 months ago

from where i can get api url ?

dhairyagothi commented 4 months ago

you have not added upi url that's why it is not working

MonishRaman commented 4 months ago

oh ok i will look over it and edit it

dhairyagothi commented 4 months ago

wait share me api website link

MonishRaman commented 4 months ago

https://developer.themoviedb.org/reference/intro/getting-started

MonishRaman commented 4 months ago

To get a TMDB (The Movie Database) API key, follow these steps:

Step 1: Create a TMDB Account Go to the TMDB website: TMDB. Click on "Login" in the top right corner. If you don't have an account, click on "Join TMDB" to create one. Follow the instructions to sign up for an account. Step 2: Verify Your Email After signing up, you will receive a verification email. Follow the link in the email to verify your account.

Step 3: Request an API Key Once your account is verified, log in to TMDB. Click on your profile icon in the top right corner and select "Settings". In the settings menu, click on "API" from the left sidebar. Click on the "Create" button to request an API key. Fill out the required information such as your application name, URL (if applicable), and a short description of your application. Agree to the terms of use and click "Submit". Step 4: Access Your API Key After submitting the form, your API key will be generated and displayed in the "API" section of your account settings. You can now use this API key in your application to access TMDB's API.

dhairyagothi commented 4 months ago

@MonishRaman check your api key and base url once it is not valid i think

MonishRaman commented 4 months ago

ok let me check that

MonishRaman commented 4 months ago

i created new api

MonishRaman commented 4 months ago

91f41d3ef950816ce6f2445e7a81ddae this is my api

MonishRaman commented 4 months ago

image

dhairyagothi commented 4 months ago

Still not working Let's merge it

MonishRaman commented 4 months ago

ok bro

github-actions[bot] commented 4 months ago

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀