Closed Meetjain1 closed 3 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
50-days-50-web-project | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 13, 2024 6:27am |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀
@dhairyagothi sorry but may I know the reason of 1 point ?
@dhairyagothi sorry but may I know the reason of 1 point ?
you just changed 2 lines of code
@dhairyagothi sorry but may I know the reason of 1 point ?
you just changed 2 lines of code
I think no. of lines doesn't matter in code , which you know well what matters is the quality. And I think this code that I added for fetching the current year automatically doesn't deserve 1 point. It's not a plain text changing or adding it's a code .
But no issue , have a gr8 day and Thanks I love to contribute in this repo.
@dhairyagothi sorry but may I know the reason of 1 point ?
you just changed 2 lines of code
I think no. of lines doesn't matter in code , which you know well what matters is the quality. And I think this code that I added for fetching the current year automatically doesn't deserve 1 point. It's not a plain text changing or adding it's a code .
But no issue , have a gr8 day and Thanks I love to contribute in this repo.
according to u how many point should i assign for this ?
@dhairyagothi sorry but may I know the reason of 1 point ?
you just changed 2 lines of code
I think no. of lines doesn't matter in code , which you know well what matters is the quality. And I think this code that I added for fetching the current year automatically doesn't deserve 1 point. It's not a plain text changing or adding it's a code . But no issue , have a gr8 day and Thanks I love to contribute in this repo.
according to u how many point should i assign for this ?
Atleast It deserves easy level , but no issue if you feel 1 point is correct for this pr . No issue at all. Thanks
@dhairyagothi sorry but may I know the reason of 1 point ?
you just changed 2 lines of code
I think no. of lines doesn't matter in code , which you know well what matters is the quality. And I think this code that I added for fetching the current year automatically doesn't deserve 1 point. It's not a plain text changing or adding it's a code . But no issue , have a gr8 day and Thanks I love to contribute in this repo.
according to u how many point should i assign for this ?
Atleast It deserves easy level , but no issue if you feel 1 point is correct for this pr . No issue at all. Thanks
Okay i will do that
Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state "None”] write issue no. here closes #262
Email id used to regsiter for VSoc'24
meetofficialhere@gmail.com
Description
[Please include a brief description of the changes or features added]
Type of PR
check in issue by entering [X] in boxes
Screenshots / Videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist
check in issue by entering [X] in boxes
Additional Context
[Include any additional information or context that might be helpful for reviewers.]
Contribution Guidelines
Thank you for considering contributing to our project! To ensure smooth collaboration and effective contribution management, please adhere to the following guidelines:
Issue Creation
Contribution Levels
Basic Contributions:
Acknowledging Hard Work:
Feature Additions and Component Work:
Level Definitions
We look forward to your contributions and appreciate your effort in helping us improve the project!