dhairyagothi / 50_days_50_web_project

This repository contains 50 web projects from basic to intermediate using html css and js Please star the repo before start working on it
https://50-days-50-web-project.vercel.app/
MIT License
29 stars 36 forks source link

Update index.html #270

Closed Meetjain1 closed 2 months ago

Meetjain1 commented 2 months ago

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state "None”] write issue no. here closes #262

Email id used to regsiter for VSoc'24

meetofficialhere@gmail.com

Description

[Please include a brief description of the changes or features added]

Type of PR

check in issue by entering [X] in boxes

Screenshots / Videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist

check in issue by entering [X] in boxes

Additional Context

[Include any additional information or context that might be helpful for reviewers.]

Contribution Guidelines

Thank you for considering contributing to our project! To ensure smooth collaboration and effective contribution management, please adhere to the following guidelines:

Issue Creation

  1. Limit on Issues:
    • Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.

Contribution Levels

  1. Basic Contributions:

    • This project is primarily focused on documentation. Most of the setup has been completed, so contributors will generally need to work on basic code tasks, such as writing tests.
    • For these tasks, issues will be assigned the Easy label.
  2. Acknowledging Hard Work:

    • If a contributor puts in significant effort on a task, the issue will be upgraded to Medium. This is our way of recognizing and appreciating extra effort.
  3. Feature Additions and Component Work:

    • Contributors working on new features or components using JSX/TSX will be assigned a level based on the complexity and quality of their work.
    • The more complex and valuable the contribution, the higher the level assigned.

Level Definitions

We look forward to your contributions and appreciate your effort in helping us improve the project!

50days

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
50-days-50-web-project ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2024 6:27am
github-actions[bot] commented 2 months ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

github-actions[bot] commented 2 months ago

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Meetjain1 commented 2 months ago

@dhairyagothi sorry but may I know the reason of 1 point ?

dhairyagothi commented 2 months ago

@dhairyagothi sorry but may I know the reason of 1 point ?

you just changed 2 lines of code

Meetjain1 commented 2 months ago

@dhairyagothi sorry but may I know the reason of 1 point ?

you just changed 2 lines of code

I think no. of lines doesn't matter in code , which you know well what matters is the quality. And I think this code that I added for fetching the current year automatically doesn't deserve 1 point. It's not a plain text changing or adding it's a code .

But no issue , have a gr8 day and Thanks I love to contribute in this repo.

dhairyagothi commented 2 months ago

@dhairyagothi sorry but may I know the reason of 1 point ?

you just changed 2 lines of code

I think no. of lines doesn't matter in code , which you know well what matters is the quality. And I think this code that I added for fetching the current year automatically doesn't deserve 1 point. It's not a plain text changing or adding it's a code .

But no issue , have a gr8 day and Thanks I love to contribute in this repo.

according to u how many point should i assign for this ?

Meetjain1 commented 2 months ago

@dhairyagothi sorry but may I know the reason of 1 point ?

you just changed 2 lines of code

I think no. of lines doesn't matter in code , which you know well what matters is the quality. And I think this code that I added for fetching the current year automatically doesn't deserve 1 point. It's not a plain text changing or adding it's a code . But no issue , have a gr8 day and Thanks I love to contribute in this repo.

according to u how many point should i assign for this ?

Atleast It deserves easy level , but no issue if you feel 1 point is correct for this pr . No issue at all. Thanks

dhairyagothi commented 2 months ago

@dhairyagothi sorry but may I know the reason of 1 point ?

you just changed 2 lines of code

I think no. of lines doesn't matter in code , which you know well what matters is the quality. And I think this code that I added for fetching the current year automatically doesn't deserve 1 point. It's not a plain text changing or adding it's a code . But no issue , have a gr8 day and Thanks I love to contribute in this repo.

according to u how many point should i assign for this ?

Atleast It deserves easy level , but no issue if you feel 1 point is correct for this pr . No issue at all. Thanks

Okay i will do that