search

dhall-lang / dhall-haskell

Maintainable configuration files
https://dhall-lang.org/
BSD 3-Clause "New" or "Revised" License
918 stars 214 forks source link

Hydra should test dhall-lsp-server #1503

Open sjakobi opened 5 years ago

sjakobi commented 5 years ago

I infer that it currently doesn't, from Hydra being green in https://github.com/dhall-lang/dhall-haskell/pull/1483 while AppVeyor fails due to failures in dhall-lsp-server:tests.

We might have to fix the doctests first, but we should do that anyways.

Gabriella439 commented 5 years ago

@sjakobi: This comment explains why it is disabled:

https://github.com/dhall-lang/dhall-haskell/blob/7ea5f6fa51dfe99f9008c3160a9cad7b6331a9cb/nix/shared.nix#L166-L168

... but it's possibly fixable. Basically, when Nix builds a project it builds the project directory in isolation, so relative references outside of the directory won't work. The way to fix this would be to actually make the entire dhall-haskell project the source directory and then cd to the dhall-lsp-server directory before proceeding to the rest of the build.