Move types needed in Dhall.DirectoryTree to own module

dhall-lang / dhall-haskell

Maintainable configuration files

https://dhall-lang.org/

BSD 3-Clause "New" or "Revised" License

908 stars 211 forks source link

Move types needed in Dhall.DirectoryTree to own module #2455

Closed mmhat closed 1 year ago

mmhat commented 1 year ago

In order to fix the Windows builds observed in #2452 we only include the FromDhall CUid and FromDhall CGid instance only if we are on that platform. Those types are not available there which caused the CI failure.

Fixes #2452

sjakobi commented 1 year ago

How come the GHA jobs aren't running for this PR? I guess this is the reason why #2452 (and #2454?!) were introduced in the first place.

I guess it's this line?!

https://github.com/dhall-lang/dhall-haskell/blob/267cae1833a63760dee7d2ba2597d13868a1984b/.github/workflows/main.yml#L6

Gabriella439 commented 1 year ago

@sjakobi: I think it's because the branch lives in a separate repo. The GitHub action probably only runs when people push branches to this repository.

Changing push to pull_request would likely fix this issue

mmhat commented 1 year ago

@sjakobi The GHA run over there: https://github.com/mmhat/dhall-haskell/actions