dhall-lang / dhall-haskell

Maintainable configuration files
https://dhall-lang.org/
BSD 3-Clause "New" or "Revised" License
912 stars 213 forks source link

dhall-1.42.0 fails to build in Stackage Nightly #2516

Closed juhp closed 11 months ago

juhp commented 1 year ago
       Building library for dhall-1.42.0..
       [69 of 77] Compiling Dhall.TH

       /var/stackage/work/unpack-dir/unpacked/dhall-1.42.0-d29671176e59c6861b5d2ff055de0a8160793e10de281c46a8279821c9efc88d/src/Dhall/TH.hs:274:38: error:
           • Couldn't match type: flag0 -> Syntax.TyVarBndr flag0
                            with: Syntax.TyVarBndr ()
             Expected: [Syntax.TyVarBndr ()]
               Actual: [flag0 -> Syntax.TyVarBndr flag0]
           • In the third argument of ‘DataD’, namely ‘params’
             In the expression:
               DataD [] name params Nothing constructors derivingClauses
             In the first argument of ‘pure’, namely
               ‘[DataD [] name params Nothing constructors derivingClauses]’
           |
       274 |                 [pure [DataD [] name params Nothing constructors derivingClauses]] <>
           |                                      ^^^^^^
sjakobi commented 1 year ago

I can reproduce this with GHC 9.0.1, 9.0.2, 9.2.4 and 9.4.4, and have made a corresponding revision on Hackage: https://hackage.haskell.org/package/dhall-1.42.0/revisions/

The issue was apparently introduced in https://github.com/dhall-lang/dhall-haskell/pull/2506 or an earlier change to that file (CC @ndwarshuis).

I don't understand why CI didn't catch this issue though – I thought the ubuntu-latest and windows-latest jobs are using GHC 9.0.1.

sjakobi commented 1 year ago

I don't understand why CI didn't catch this issue though – I thought the ubuntu-latest and windows-latest jobs are using GHC 9.0.1.

These jobs don't make use of the installed "Haskell environment" though – they use stack with lts-18.18 which is based on GHC-8.10.7.

I guess it's high time to add CI with a recent version of GHC.

alaendle commented 1 year ago

@sjakobi - to enable dhall-1.42.0 in nightly we also need relaxed bounds for template-haskell and unix-compat.

template-haskell-2.19.0.0 (changelog) is out of bounds for:

unix-compat-0.7 (changelog) (Mitchell Rosen mitchellwrosen@gmail.com @mitchellwrosen) is out of bounds for:

ocharles commented 1 year ago

I think it's more than relaxing bounds for unix-compat - dhall-1.42 doesn't build with unix-compat-0.7.

chenrui333 commented 11 months ago

any update on this thread?

ysangkok commented 11 months ago

It was fixed in https://github.com/dhall-lang/dhall-haskell/pull/2542

On Thu, Oct 26, 2023, 22:01 Rui Chen @.***> wrote:

any update on this thread?

— Reply to this email directly, view it on GitHub https://github.com/dhall-lang/dhall-haskell/issues/2516#issuecomment-1782254030, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACFK53TULOGX6IZB3FLU4TYBMW2VAVCNFSM6AAAAAAXFVSSJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBSGI2TIMBTGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Gabriella439 commented 11 months ago

Yeah, I'm closing this as I'm fairly confident this is fixed in master and will be fixed in the next release of dhall. (I've been meaning to release it soon, but have just been very busy, but I hope to get to cutting the release this Sunday)