search

dhall-lang / dhall-haskell

Maintainable configuration files
https://dhall-lang.org/
BSD 3-Clause "New" or "Revised" License
908 stars 211 forks source link

lsp-server: Compatibility with lsp ==2.3.0.0 #2571

Open rvl opened 4 months ago

rvl commented 4 months ago

This change lets dhall-lsp-server build and pass unit tests with lsp-2.3.0.0.

The PR is in draft until the Hydra build works.

I've done some light testing of this build with vscodium. Type-checking and completion seem to work.

Gabriella439 commented 4 months ago

If you merge https://github.com/rvl/dhall-haskell/pull/1 I think that will fix the build failures

rvl commented 4 months ago

Thanks @Gabriella439, that's merged now.

About stack.ghc-8.10.yaml -- I'm not sure whether lsp-2.3.0.0 will build with Stackage LTS 18.28. :question: So even though dhall works with ghc-8.10, dhall-lsp-server may not.

Gabriella439 commented 4 months ago

I wouldn't worry about it. I don't think people use those other stack-*.yaml files that much and if they have any issues they'll put up a PR to fix them.