search

dhall-lang / dhall-haskell

Maintainable configuration files
https://dhall-lang.org/
BSD 3-Clause "New" or "Revised" License
908 stars 211 forks source link

enable macos 86/arm release #2590

Closed winitzki closed 1 month ago

winitzki commented 1 month ago

The build should create macos-x86_64 and macos-arm64 executables and publish them.

winitzki commented 1 month ago

@mmhat I could not follow one of your comments in the previous PR:

Also use runner.arch in the conditional executions here:


if [ '${{matrix.os.runner}}' == 'windows-latest' ] && [ "${package}" == 'dhall-nix' ]; then

...

if [ '${{matrix.os.runner}}' == 'windows-latest' ] && [ "${package}" == 'dhall-nix' ]; then 



I'm not sure how to modify those conditionals to use `runner.arch`. Right now we have only one runner under windows.
winitzki commented 1 month ago

@mmhat I followed your comments in the previous PR but it seems I'm doing something wrong. There is an error with main.yml saying that runner is undefined.

https://github.com/dhall-lang/dhall-haskell/actions/runs/9318616557

mmhat commented 1 month ago

@winitzki Oh I guess I didn't read the docs thoroughly... The runner context is of course only available when we have a runner :slightly_smiling_face: At line 35 of the failed job you linked we do not have a runner yet, that part is interpreted before a runner picks up a job of the workflow.

TLDR; We can only use the runner context inside the steps; I.e. whenever we could write shell code then the runner context is available there. That's at least how I understand the docs...

EDIT: See https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability for the availability of the different contexts.

mmhat commented 1 month ago

@winitzki Nice work!

winitzki commented 1 month ago

@winitzki Nice work!

Thank you for your timely help!