Does not build

[ababkin]

getting following error when trying to stack install (looks like it's missing None and Some from the newer Dhall.Core)

Preprocessing library for dhall-json-1.2.3..
Building library for dhall-json-1.2.3..
[1 of 1] Compiling Dhall.JSON       ( src/Dhall/JSON.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Dhall/JSON.o )

/Users/ababkin/work/dhall-json/src/Dhall/JSON.hs:252:9: error:
    Not in scope: data constructor ‘Dhall.Core.Some’
    Perhaps you meant one of these:
      ‘Dhall.Core.Home’ (imported from Dhall.Core),
      ‘Dhall.Core.Note’ (imported from Dhall.Core),
      ‘Dhall.Core.Code’ (imported from Dhall.Core)
    Module ‘Dhall.Core’ does not export ‘Some’.
    |
252 |         Dhall.Core.Some a -> do
    |         ^^^^^^^^^^^^^^^

/Users/ababkin/work/dhall-json/src/Dhall/JSON.hs:255:24: error:
    Not in scope: data constructor ‘Dhall.Core.None’
    Perhaps you meant one of these:
      ‘Dhall.Core.Note’ (imported from Dhall.Core),
      ‘Dhall.Core.Home’ (imported from Dhall.Core),
      ‘Dhall.Core.Code’ (imported from Dhall.Core)
    Module ‘Dhall.Core’ does not export ‘None’.
    |
255 |         Dhall.Core.App Dhall.Core.None _ -> do
    |                        ^^^^^^^^^^^^^^^

/Users/ababkin/work/dhall-json/src/Dhall/JSON.hs:602:9: error:
    Not in scope: data constructor ‘Dhall.Core.Some’
    Perhaps you meant one of these:
      ‘Dhall.Core.Home’ (imported from Dhall.Core),
      ‘Dhall.Core.Note’ (imported from Dhall.Core),
      ‘Dhall.Core.Code’ (imported from Dhall.Core)
    Module ‘Dhall.Core’ does not export ‘Some’.
    |
602 |         Dhall.Core.Some a ->
    |         ^^^^^^^^^^^^^^^

/Users/ababkin/work/dhall-json/src/Dhall/JSON.hs:603:13: error:
    Not in scope: data constructor ‘Dhall.Core.Some’
    Perhaps you meant one of these:
      ‘Dhall.Core.Home’ (imported from Dhall.Core),
      ‘Dhall.Core.Note’ (imported from Dhall.Core),
      ‘Dhall.Core.Code’ (imported from Dhall.Core)
    Module ‘Dhall.Core’ does not export ‘Some’.
    |
603 |             Dhall.Core.Some a'
    |             ^^^^^^^^^^^^^^^

/Users/ababkin/work/dhall-json/src/Dhall/JSON.hs:607:9: error:
    Not in scope: data constructor ‘Dhall.Core.None’
    Perhaps you meant one of these:
      ‘Dhall.Core.Note’ (imported from Dhall.Core),
      ‘Dhall.Core.Home’ (imported from Dhall.Core),
      ‘Dhall.Core.Code’ (imported from Dhall.Core)
    Module ‘Dhall.Core’ does not export ‘None’.
    |
607 |         Dhall.Core.None ->
    |         ^^^^^^^^^^^^^^^

/Users/ababkin/work/dhall-json/src/Dhall/JSON.hs:608:13: error:
    Not in scope: data constructor ‘Dhall.Core.None’
    Perhaps you meant one of these:
      ‘Dhall.Core.Note’ (imported from Dhall.Core),
      ‘Dhall.Core.Home’ (imported from Dhall.Core),
      ‘Dhall.Core.Code’ (imported from Dhall.Core)
    Module ‘Dhall.Core’ does not export ‘None’.
    |
608 |             Dhall.Core.None
    |             ^^^^^^^^^^^^^^^

Completed 94 action(s).

[Gabriella439]

@ababkin: This is because the master branch of this repository depends on an unpublished release of the master branch of the dhall package. I will be cutting a release for both packages soon

[jneira]

@ababkin in the meanwhile, you could modify the stack.yaml to use the master version of dhall:

resolver: lts-12.12
extra-deps:
  - github: dhall-lang/dhall-haskell
    commit: f4a65634c3e0c0ff45c9c6adf907127238c67c6e
  - megaparsec-7.0.1
  - repline-0.2.0.0
  - serialise-0.2.0.0

[jneira]

Well, i am getting errors about InsOrdHashMap with that config too, i am taking a look

[jneira]

I've created a pr using the dhall-haskell version of https://github.com/dhall-lang/dhall-haskell/pull/624, needed to complete the adaption

[jneira]

@ababkin as maybe you already know, if you need to build it before the pr would be merged you can build it with git fetch origin pull/63/head:branch-name && git checkout branch-name && stack install

[Gabriella439]

Check to see if it builds now

[ababkin]

master builds perfectly now, thank you!

[Gabriella439]

You're welcome! 🙂