Adapt to new Dhall.Map - Githubissues

dhall-lang / dhall-json

This repository has moved to https://github.com/dhall-lang/dhall-haskell/tree/master/dhall-json

BSD 3-Clause "New" or "Revised" License

65 stars 6 forks source link

Adapt to new Dhall.Map #63

Closed jneira closed 5 years ago

jneira commented 5 years ago

Changes to adapt dhall-json to the new incoming dhall-haskell version
As dhall-json needs the changes of https://github.com/dhall-lang/dhall-haskell/pull/624, i've pinned its version in the stack.yaml. Only it will have to change with the new release.

jneira commented 5 years ago

The nix build has failed, as i am on windows dont know if i am able to compute the sha of the dhall-haskell commit to update nix/dhall.nix :thinking:

jneira commented 5 years ago

I've added a cabal.project to make it buildable with cabal-2.4.0.0, after the release we should remove the source-repository-package stanza (however i would keep cabal.project)

Gabriella439 commented 5 years ago

@jneira: Oh, whoops. I actually already did the work to build against the new Dhall.Map but I forgot to open a pull request for. I can open a pull request with the changes I had in my local repository

Gabriella439 commented 5 years ago

Actually, the two branches are close enough that I can just open a pull request against your pull request

Gabriella439 commented 5 years ago

@jneira: Alright, I have a pull request open against your branch here: https://github.com/jneira/dhall-json/pull/1

Once you merge that then this pull request will pass

jneira commented 5 years ago

Merged!